pvary commented on a change in pull request #2129:
URL: https://github.com/apache/iceberg/pull/2129#discussion_r561897503
##########
File path: mr/src/main/java/org/apache/iceberg/mr/InputFormatConfig.java
##########
@@ -73,6 +74,10 @@ private InputFormatConfig() {
public static final String SNAPSHOT_TABLE = "iceberg.snapshots.table";
public static final String SNAPSHOT_TABLE_SUFFIX = "__snapshots";
+ public static final String CATALOG_TYPE_TEMPLATE = CATALOG_NAME + ".%s.type";
Review comment:
I think we reused here the CATALOG_NAME constant, which was supposed to
be something else.
Maybe `CATALOG_CONFIG_PREFIX_`?
The value could be `iceberg.catalog.` or simply just omit?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
