rshdhere commented on issue #11554: URL: https://github.com/apache/iceberg/issues/11554#issuecomment-6129629193
Hi @haizhou-zhao, thanks for writing this up so clearly, and thanks @dramaticlly for the pointer to #9225. I checked current `main` and this still applies. `testCreateTableCommitProperties` is still skipped for the REST catalog in all four Spark versions ([v4.2 for example](https://github.com/apache/iceberg/blob/256f542d3e9f50f97fabf4ffea498f151fb44820/spark/v4.2/spark/src/test/java/org/apache/iceberg/spark/sql/TestCreateTable.java#L344-L347)). `DefaultErrorHandler` turns a 400 back into an `IllegalArgumentException` when the error type matches, but it has nothing similar for `ValidationException` ([here](https://github.com/apache/iceberg/blob/256f542d3e9f50f97fabf4ffea498f151fb44820/core/src/main/java/org/apache/iceberg/rest/ErrorHandlers.java#L337-L341)). I'd like to pick this up if that's okay. Building on @dramaticlly's idea, I'd add the same kind of mapping for `ValidationException` in `ErrorHandlers` with a unit test, then drop the `assumeThat` so the test runs against REST too. If you'd rather keep it as a `BadRequestException` and only adjust the test, I'm happy to go that way instead. Could someone assign this to me if either direction sounds good? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
