nastra commented on code in PR #18387:
URL: https://github.com/apache/iceberg/pull/18387#discussion_r4247143109
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/data/TestOrcWrite.java:
##########
@@ -56,4 +57,26 @@ public void splitOffsets() throws IOException {
writer.close();
assertThat(writer.splitOffsets()).as("Split offsets not
present").isNotEmpty();
}
+
+ @Test
+ public void variantIsNotSupported() throws IOException {
Review Comment:
this only covers the write path. Can we also have a test for the two read
paths that are modified?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
