singhpk234 commented on code in PR #18472:
URL: https://github.com/apache/iceberg/pull/18472#discussion_r4253234790
##########
core/src/main/java/org/apache/iceberg/rest/responses/FetchScanTasksResponseParser.java:
##########
@@ -69,12 +70,25 @@ static FetchScanTasksResponse fromJson(
public static FetchScanTasksResponse fromJson(
JsonNode json, Map<Integer, PartitionSpec> specsById, boolean
caseSensitive) {
+ return fromJson(json, specsById, caseSensitive, null);
+ }
Review Comment:
same here
##########
core/src/main/java/org/apache/iceberg/rest/responses/FetchPlanningResultResponseParser.java:
##########
@@ -92,6 +93,18 @@ static FetchPlanningResultResponse fromJson(
public static FetchPlanningResultResponse fromJson(
JsonNode json, Map<Integer, PartitionSpec> specsById, boolean
caseSensitive) {
+ return fromJson(json, specsById, caseSensitive, null);
+ }
Review Comment:
should we mark this deprecated then ?
##########
core/src/main/java/org/apache/iceberg/rest/TableScanResponseParser.java:
##########
@@ -66,6 +67,19 @@ public static List<FileScanTask> parseFileScanTasks(
List<DeleteFile> deleteFiles,
Map<Integer, PartitionSpec> specsById,
boolean caseSensitive) {
+ return parseFileScanTasks(node, deleteFiles, specsById, caseSensitive,
null);
+ }
Review Comment:
same here : can we mark this deprecated ?
##########
core/src/main/java/org/apache/iceberg/rest/RESTFileScanTaskParser.java:
##########
@@ -94,7 +95,10 @@ public static FileScanTask fromJson(
deleteFiles =
indices.stream().map(allDeleteFiles::get).toArray(DeleteFile[]::new);
}
- Expression filter = null;
+ // A missing residual-filter is allowed by the spec, and the client must
then produce the
+ // residual: the ResidualEvaluator below derives it from the scan filter
and the task's
+ // partition.
Review Comment:
wouldn't it be simpler if we say, use the scanFilter if the residual is
missing ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
