anoopj commented on code in PR #3416:
URL: https://github.com/apache/iceberg-rust/pull/3416#discussion_r4253271835
##########
crates/iceberg/src/expr/visitors/row_group_metrics_evaluator.rs:
##########
@@ -591,6 +597,30 @@ mod tests {
Ok(())
}
+ #[test]
+ fn eval_error_for_not_predicate_requires_rewrite() -> Result<()> {
+ // The evaluator cannot soundly negate a conservative bound, so a NOT
node
+ // that reaches it (one that was not rewritten away first) is rejected
+ // rather than silently mispruning a matching row group.
+ let row_group_metadata = create_row_group_metadata(1, 1, None, 1,
None)?;
+
+ let (iceberg_schema_ref, field_id_map) =
build_iceberg_schema_and_field_map()?;
+
+ let filter =
(!Reference::new("col_float").greater_than(Datum::float(5.0_f32)))
+ .bind(iceberg_schema_ref.clone(), false)?;
+
+ let result = RowGroupMetricsEvaluator::eval(
+ &filter,
+ &row_group_metadata,
+ &field_id_map,
+ iceberg_schema_ref.as_ref(),
+ );
+
+ assert!(result.is_err());
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
