zhjwpku commented on code in PR #976: URL: https://github.com/apache/iceberg-cpp/pull/976#discussion_r4256423346
########## src/iceberg/catalog/rest/json_serde.cc: ########## @@ -110,6 +111,8 @@ constexpr std::string_view kDeleteFileReferences = "delete-file-references"; constexpr std::string_view kResidualFilter = "residual-filter"; constexpr std::string_view kStart = "start"; constexpr std::string_view kLength = "length"; +constexpr std::string_view kMapKeys = "keys"; +constexpr std::string_view kMapValues = "values"; Review Comment: Will these be used in follow-ups? ########## src/iceberg/catalog/rest/json_serde.cc: ########## @@ -18,6 +18,7 @@ */ #include <iterator> +#include <limits> Review Comment: This is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
