gaborkaszab commented on code in PR #18481:
URL: https://github.com/apache/iceberg/pull/18481#discussion_r4256530052
##########
data/src/main/java/org/apache/iceberg/data/GenericDeleteFilter.java:
##########
@@ -18,20 +18,29 @@
*/
package org.apache.iceberg.data;
+import java.util.function.Function;
import org.apache.iceberg.FileScanTask;
import org.apache.iceberg.Schema;
import org.apache.iceberg.StructLike;
import org.apache.iceberg.io.FileIO;
import org.apache.iceberg.io.InputFile;
public class GenericDeleteFilter extends DeleteFilter<Record> {
- private final FileIO io;
+ private final Function<String, InputFile> inputFiles;
private final InternalRecordWrapper asStructLike;
public GenericDeleteFilter(
FileIO io, FileScanTask task, Schema tableSchema, Schema
requestedSchema) {
+ this(io::newInputFile, task, tableSchema, requestedSchema);
Review Comment:
This is still used by `IcebergInputFormat` in mr. As a follow-up step I'll
try to get rid of that usage too.
Once that's done, since this is public API, should be deprecated and the
`InputFilesDecryptor` based way should be recommended, to guarantee decrypting
these files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
