JeonDaehong opened a new pull request, #3433: URL: https://github.com/apache/iceberg-rust/pull/3433
## Which issue does this PR close? - Closes #3344. Continues #3345 by @unikdahal, who is away for a few weeks and offered it up in #3343. The original commit is credited with `Co-authored-by`. ## What changes are included in this PR? Same feature as #3345, rebased on #3145, with one change from the review there: an unknown size is `None` instead of a `0` sentinel. - `FileScanTaskDeleteFile::file_size_in_bytes()` now returns `Option<u64>`. Tasks planned from manifests always carry `Some`. - Builder: `.with_file_size_in_bytes(n)` is unchanged; leave it unset (or use `.with_file_size_in_bytes_opt`) when the size is unknown. - When the size is `None`, the Parquet delete-file loader resolves it with one metadata request on first load. A size below the Parquet footer minimum, including `Some(0)`, is rejected instead of dropping the file's deletes. - Deletion vectors don't use this size and are unchanged. ## Are these changes tested? Yes. The tests from #3345 are kept, adapted to the builder (private fields after #3145), plus a `Some(0)` case. `cargo test -p iceberg --lib` (1957 passed), `cargo clippy --workspace --all-targets -- -D warnings` and `cargo fmt --check` are clean. `public-api.txt` is updated for the getter. ## AI Disclosure I used Claude Code to help with the rebase and the `Option<u64>` change. I reviewed the code and ran the tests and lints above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
