David-Banquet commented on PR #3838: URL: https://github.com/apache/iceberg-python/pull/3838#issuecomment-6147026774
@lemon0333 I'd like to see this land, so I rebased it on today's main to check where it stands: it applies cleanly and `tests/catalog/test_glue.py` + `test_dynamodb.py` pass (98 tests, including your 7 role tests), ruff is clean. One thing I'd raise before a maintainer review: `_get_aws_session_with_assumed_role` builds the session from the static credentials of a single `AssumeRole` call, so `session.get_credentials()` is a plain `Credentials` with no refresh. A long-lived process (a service holding a `GlueCatalog`) starts getting `ExpiredToken` once the role session ends, one hour by default. The S3 FileIO does not have this problem as far as I can tell, since it hands the ARN to Arrow, which refreshes through the SDK's STS provider. botocore can do the same here with `AssumeRoleCredentialFetcher` + `DeferredRefreshableCredentials`. Do you want to reopen this and carry on? If you don't have time for it anymore, I'm happy to open a new PR from your commit with the refresh added, keeping you as co-author. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
