CTTY commented on code in PR #3265:
URL: https://github.com/apache/iceberg-rust/pull/3265#discussion_r4263733351


##########
crates/iceberg/src/transaction/append.rs:
##########
@@ -87,7 +88,13 @@ impl FastAppendAction {
 
 #[async_trait]
 impl TransactionAction for FastAppendAction {

Review Comment:
   Because FastAppend will still need a snapshot producer at some point to 
persist metadata rather than just generating `ActionCommit`. We will need to 
wire that after converting the existing the SnapshotProducer into a 
TransactionState



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to