JeonDaehong commented on code in PR #3433:
URL: https://github.com/apache/iceberg-rust/pull/3433#discussion_r4259902355
##########
crates/iceberg/src/scan/task.rs:
##########
@@ -612,7 +618,8 @@ mod _serde {
#[derive(Deserialize)]
pub(super) struct FileScanTaskDeleteFileSerde {
file_path: String,
- file_size_in_bytes: u64,
+ #[serde(default)]
+ file_size_in_bytes: Option<u64>,
Review Comment:
Added `test_delete_file_without_size_round_trips_through_serde` next to that
test in b2981e2ea. It checks that the field is left out when serializing and
that a task without it reads back as `None`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
