wroever commented on code in PR #1984:
URL: https://github.com/apache/iceberg-go/pull/1984#discussion_r4266911932
##########
manifest.go:
##########
@@ -917,6 +917,11 @@ func (c *ManifestReader) ReadEntry() (ManifestEntry,
error) {
if c.isFallback {
tmp = tmp.(*fallbackManifestEntry).toEntry()
}
+ if df, ok := tmp.DataFile().(*dataFile); ok {
+ if err := df.normalizeFormat(); err != nil {
+ return nil, err
Review Comment:
Would push back on this one: the errors below don't actually use the
`iceberg:` prefix so I think adding the prefix here would be out of convention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
