plusplusjiajia commented on PR #892: URL: https://github.com/apache/iceberg-cpp/pull/892#issuecomment-6168039273
@wgtmac Thanks! Rebased onto main. The first commit is the previous one rebased; the second addresses this round. Since #783 made `Get` virtual, the timeout is a parameter without a default, so callers and the two mocks pass it. A refresh now only rotates keys, which keeps it simple and safe to run from a request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
