rshdhere commented on PR #18506: URL: https://github.com/apache/iceberg/pull/18506#issuecomment-6169017716
Nice catch! A `-1` failing deep inside `allDeleteFiles.get()` would've been confusing to track down, so it's good to fail early with a clear message instead. Small optional thought: I noticed the upper-bound check right below doesn't have a test either. If you feel like it, a quick parameterized test with `[-1]` and `[1]`would cover both sides. Totally fine to leave it for a follow-up though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
