swanandx commented on code in PR #3277:
URL: https://github.com/apache/iceberg-rust/pull/3277#discussion_r4271820399
##########
crates/iceberg/src/arrow/reader/pipeline.rs:
##########
@@ -91,9 +91,22 @@ impl ArrowReader {
.try_flatten(),
)
} else {
+ let runtime = self.runtime.clone();
Box::pin(
tasks
- .map_ok(move |task| task_reader.clone().process(task))
+ .map_ok(move |task| {
+ // Open the file on the IO runtime. The flatten below
stops polling
+ // the opens once it holds
`concurrency_limit_data_files` streams, and
+ // a half-read response keeps part of the HTTP/2
connection window,
+ // which stalls every other read on that connection.
+ let opening =
runtime.io().spawn(task_reader.clone().process(task));
Review Comment:
Thanks for the detailed feedback and suggestions, i totally missed that we
must abort on drop.
took help from Claude for this / tests.
Fixed in
https://github.com/apache/iceberg-rust/pull/3277/changes/fa551d9fe031333803d49eaf9c1bfb4e349a9d50
[ seperate commit for easier review, can amend later if all good ]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
