szlta commented on code in PR #17155:
URL: https://github.com/apache/iceberg/pull/17155#discussion_r4272089195
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -4248,6 +4300,13 @@ components:
Credentials for ADLS / GCS / S3 / ... are provided through the
`storage-credentials` field.
Clients must first check whether the respective credentials exist in
the `storage-credentials` field before checking the `config` for credentials.
+ ## Key Management Credentials
+
+ Credentials for KMS / key-management systems are provided through the
`key-management-credentials` field.
+ Clients must first check whether KMS credentials exist in the
`key-management-credentials`
+ field before checking the `config` map for KMS credential
configuration.
Review Comment:
Agreed with @singhpk234 - the legacy outer config bag holding storage
credentials is only for backward compatibility.
I'd avoid doing this for KMS since this proposal already allows different
parts of the table to be encrypted by different KMS keys, kind of like how the
current spec also allows prefixed / structured storage credentials
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
