vladislav-sidorovich commented on code in PR #16848:
URL: https://github.com/apache/iceberg/pull/16848#discussion_r4272588704
##########
gcp/src/test/java/org/apache/iceberg/gcp/auth/TestGoogleAuthManager.java:
##########
@@ -221,6 +228,45 @@ public void initializationOccursOnlyOnce() {
mockedStaticCredentials.verify(GoogleCredentials::getApplicationDefault,
times(1));
}
+ @Test
+ public void concurrentInitialization() throws Exception {
Review Comment:
I'm a bit confused by this comment.
`initialzationOccursOnlyOnce` executed in a single thread, this
`concurrentInitialization` executed in 10 threads and detect the race
condition. It's the reason for this test.
Actually, we can delete `initialzationOccursOnlyOnce` and leave only this.
What do you think?
Concurrent tests are non-deterministic by design. Concurrent tests verify
that after `N` executions an object under test stays in a valid state (depends
on the scenario). What do you suggest to do with this test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
