rambleraptor commented on code in PR #133:
URL:
https://github.com/apache/terraform-provider-iceberg/pull/133#discussion_r4274027333
##########
dev/release/release_rc.sh:
##########
@@ -138,23 +138,23 @@ if [ "${RELEASE_SIGN}" -gt 0 ]; then
--repo "${repository}" \
"${id}/${rc_tar_gz}.asc"
- echo "Signing the binary checksums (SHA256SUMS) for the registry"
- rm -rf binaries-rc
- mkdir -p binaries-rc
- gh release download "${rc_tag}" \
- --dir binaries-rc \
- --pattern "${sha256sums}" \
- --repo "${repository}" \
- --skip-existing
- (
- cd binaries-rc
- gpg --batch --yes --detach-sign --output "${sha256sums}.sig"
"${sha256sums}"
- )
- echo "Adding the SHA256SUMS signature to the prerelease"
- gh release upload "${rc_tag}" \
- --clobber \
- --repo "${repository}" \
- "binaries-rc/${sha256sums}.sig"
+ # Signatures are now done by CI via ATR
Review Comment:
What's the idea behind keeping these as comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
