pvary commented on code in PR #18416: URL: https://github.com/apache/iceberg/pull/18416#discussion_r4276237447
########## format/spec.md: ########## @@ -295,6 +297,12 @@ For details on how to serialize a schema to JSON, see Appendix C. [1001]: <https://portal.ogc.org/files/?artifact_id=25355> "OGC Simple feature access" +##### Vector + +Every non-null `vector(E, D)` value must contain exactly D non-null elements of type E. Floating-point elements must not be `NaN`, positive infinity, or negative infinity. The vector value itself may be null when the containing field is optional. + +No type promotion to or from `vector` is defined, including changes to its element type or dimension. Lower and upper bounds are not defined for vector values. Review Comment: Thanks for digging into this! I think adding int8 and float16 is a relatively small spec change, see #18485. It gives us a safe, future-proof way to store these values, and AI workloads rely heavily on these smaller types. Parquet already defines a representation for both (`INT(8, true)` on int32, and `FLOAT16`), so we can reuse it rather than wait for the file formats. If we go this way, the width becomes part of the schema, engines know the size up front and can plan their internal representation and query plan accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
