Copilot commented on code in PR #1019:
URL: https://github.com/apache/iceberg-cpp/pull/1019#discussion_r4278479363
##########
.github/workflows/test.yml:
##########
@@ -56,8 +56,8 @@ jobs:
extra_cmake_args: "-DICEBERG_CXX20_COMPAT=ON"
api_mode: C++20 Compat
- cmake_build_type: RelWithDebInfo
- extra_cmake_args: ""
- api_mode: C++23
+ extra_cmake_args: "-DICEBERG_BUILD_STATIC=OFF
-DICEBERG_BUILD_SHARED=ON"
Review Comment:
This makes the full build shared-only while `ICEBERG_BUILD_BUNDLE` remains
ON. `avro_test` then links against `iceberg_bundle_shared`, but it directly
constructs `AvroInputStream` and `AvroOutputStream`, whose out-of-line
constructors lack export annotations
(`src/iceberg/avro/avro_stream_internal.h:27–30,65–68`). The shared library
uses hidden visibility, so the job fails with undefined references before
running tests. Retain the existing full-build configuration and add a separate
bundle-disabled shared-only job without bundle-dependent example/integration
steps, or export the bundle interfaces required by its tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
