HenryCaiHaiying commented on code in PR #17025:
URL: https://github.com/apache/iceberg/pull/17025#discussion_r4279336056


##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/Worker.java:
##########
@@ -110,16 +117,29 @@ protected boolean receive(Envelope envelope) {
 
     send(events, results.sourceOffsets());
 
+    long fileCount =
+        results.writerResults().stream()
+            .mapToLong(result -> result.dataFiles().size() + 
result.deleteFiles().size())

Review Comment:
   I think I would just split into 2 counters: data-files-written and 
delete-files-written and update the proposal doc.  By the way, I haven't see 
anyone replied to my original email thread on dev@ email alias nor commenting 
on the proposal doc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to