kacper-li-airspace-intelligence opened a new pull request, #3447:
URL: https://github.com/apache/iceberg-rust/pull/3447

   ## Which issue does this PR close?
   
   - Closes #3445.
   
   ## What changes are included in this PR?
   
   Stacked on #3224; only the last commit is new.
   
   `ManifestFileV1` only knows `added_data_files_count`, 
`existing_data_files_count` and `deleted_data_files_count`. Java and the spec 
use `added_files_count`, `existing_files_count` and `deleted_files_count`, so 
these counts in V1 lists written by Java parse as `None`. Add the serde aliases 
`ManifestFileV2` already has. This relies on #3224 reading V1 against the 
writer schema; resolution against `MANIFEST_LIST_AVRO_SCHEMA_V1` filled the old 
names with null before serde saw the record.
   
   ## Are these changes tested?
   
   `test_parse_manifest_list_v1_with_spec_field_names` writes a V1 list with 
the spec field names and parses it. It fails without the aliases.
   
   ## AI Disclosure
   
   AI assisted with the implementation, test and description.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to