Copilot commented on code in PR #3457:
URL: https://github.com/apache/iceberg-rust/pull/3457#discussion_r4274842714
##########
.github/workflows/release_python_nightly.yml:
##########
@@ -28,7 +28,7 @@ permissions:
jobs:
set-version:
if: github.repository == 'apache/iceberg-rust' || github.event_name ==
'workflow_dispatch' # Run on schedule for apache repo, or on manual dispatch
from any repo
- runs-on: ubuntu-latest
+ runs-on: ubuntu-slim
Review Comment:
`runs-on: ubuntu-slim` is likely an org-specific runner label; this job
explicitly allows `workflow_dispatch` from any repo (including forks), which
can cause manual runs to fail with “no runner matching the specified labels”.
Consider making `runs-on` conditional (use `ubuntu-slim` only when
`github.repository_owner == 'apache'`, otherwise fall back to
`ubuntu-24.04`/`ubuntu-latest`), or tighten the `if:` so the job only runs
where `ubuntu-slim` is available.
##########
.github/workflows/asf-allowlist-check.yml:
##########
@@ -32,7 +32,7 @@ permissions:
jobs:
asf-allowlist-check:
- runs-on: ubuntu-24.04
+ runs-on: ubuntu-slim
Review Comment:
If `ubuntu-slim` is not available on forks (common for org-specific runner
labels), this workflow can fail for external contributors depending on its
triggers. To keep contributor PRs green, make `runs-on` conditional on
`github.repository_owner == 'apache'` with a fallback runner label, or add an
`if:` guard so it only runs in contexts where `ubuntu-slim` is guaranteed to
exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
