danielcweeks commented on code in PR #17822: URL: https://github.com/apache/iceberg/pull/17822#discussion_r4287698719
########## format/spec.md: ########## @@ -442,6 +443,8 @@ Two rows are the "same"---that is, the rows represent the same entity---if the i Identifier fields may be nested in structs but cannot be nested within maps or lists. Float, double, and optional fields cannot be used as identifier fields and a nested field cannot be used as an identifier field if it is nested in an optional struct, to avoid null values in identifiers. +Identifier field IDs must not be used in v4, where a [`primary-key` constraint](#constraints) expresses the same concept. Review Comment: ```suggestion Identifier field IDs are replaced by [`primary-key` constraint](#constraints) in v4 and must not be included in table metadata. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
