rshdhere opened a new pull request, #18530: URL: https://github.com/apache/iceberg/pull/18530
The scenario in #16662 (rewrite position delete files, expire the snapshot that added the old ones, then run `rewrite_table_path`) no longer fails on main. #15470 changed the action to collect position delete files with a `ManifestReader`, which returns only live entries, so DELETED entries whose files were removed by expiration are no longer opened. Nothing in the test suite covered this case, so this adds a regression test. Run against the commit before #15470, the same test fails with `NotFoundException: File does not exist: .../old-deletes.parquet`; on main it passes. The core-only fix proposed in #16669 is no longer needed for this path. **Test plan:** `positionDeletesRewrittenAndExpired` (v2) checks that the expired delete file is gone, that only the live delete file is rewritten, and that the copied target table reads the expected row. Closes #16662 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
