danielcweeks commented on code in PR #17822: URL: https://github.com/apache/iceberg/pull/17822#discussion_r4289010706
########## format/spec.md: ########## @@ -1848,6 +1959,8 @@ Schemas are serialized as a JSON object with the same fields as a struct in the | _optional_ | _required_ |**`schema-id`**|`JSON int`|`0`| | _optional_ | _optional_ |**`identifier-field-ids`**|`JSON list of ints`|`[1, 2]`| +`identifier-field-ids` must not be used in v4, where a [`primary-key` constraint](#constraints) expresses the same concept. Review Comment: ```sql In v4, [`primary-key` constraint](#constraints) replaces `identifier-field-ids`. ``` I'd simply this and add a v4 column to the table above with _removed_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
