mkroll-db commented on code in PR #3463: URL: https://github.com/apache/iceberg-rust/pull/3463#discussion_r4290556670
########## CHANGELOG.md: ########## @@ -33,6 +33,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/). * `EncryptedInputFile::metadata()` is now synchronous and derives the plaintext size from key metadata without a storage stat. Remove `.await` from calls to this method. * AGS1 readers now require `StandardKeyMetadata::file_length` and reject missing or invalid lengths without falling back to a storage stat. AGS1-encrypted manifests, manifest lists, and Puffin files written by earlier development builds without this field must be rewritten using a build that can still read them before upgrading. This matches the Java client's read contract. * `iceberg_catalog_loader::BoxedCatalogBuilder` has a new required method, `with_runtime`. Types implementing `CatalogBuilder` get it through the blanket impl; types implementing `BoxedCatalogBuilder` directly (for example, a wrapper around another `Box<dyn BoxedCatalogBuilder>`) must implement it, typically by forwarding the runtime to the builder they wrap. +* `Transaction::commit` now fails with `ErrorKind::PreconditionFailed` for read-only tables instead of committing them. Handle the error in callers that commit to a table obtained from `StaticTable::into_table`. Review Comment: You're right this is much better. Let me apply it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
