blackmwk opened a new pull request, #3478: URL: https://github.com/apache/iceberg-rust/pull/3478
## Which issue does this PR close? Follow-up to the [review comments on #3102](https://github.com/apache/iceberg-rust/pull/3102#pullrequestreview-5537777272). Relates to #3096. ## What changes are included in this PR? Pin the contract that Glue forwards the full input map to its KMS factory, including URI, catalog ID, warehouse, and custom properties. A recording factory returns an error before AWS client initialization, covering both the property handoff and error propagation. Warehouse validation failures identify the missing or empty case. The existing `GlueCatalog` debug output excludes the raw property map, so AWS secret keys and session tokens are no longer printed. ## Are these changes tested? Using the pinned `nightly-2026-04-16` toolchain: - `cargo test --locked -p iceberg-catalog-glue --lib` — 20 passed. - `cargo clippy --locked -p iceberg-catalog-glue --all-targets -- -D warnings`. - `cargo fmt --all -- --check` and `git diff --check`. ## AI Disclosure OpenAI Codex assisted with the tests and documentation. Review focus: the recording factory deliberately aborts initialization, so coverage is limited to the KMS property handoff and error propagation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
