hreddygayam commented on PR #18537: URL: https://github.com/apache/iceberg/pull/18537#issuecomment-6214520753
Pushed an update: - Addressed @mxm's comments on the generic binding - convert the constant up front like the Flink binding (reusing `structLikeToRecord`), dropped the `asRecord` normalization, and made the test class package-private. - @pvary, on testing the geo boundaries in the metrics test - added `testDataWriterGeospatialBounds`. It writes geometry columns and checks the file's lower/upper bounds come back as the expected bounding-box corners (decoded via `GeospatialBound`). Runs on Parquet; skipped for Avro/ORC via the usual feature assumptions. - Left a note inline on the Spark 4.1/4.2 geo question. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
