gaborkaszab commented on PR #17545: URL: https://github.com/apache/iceberg/pull/17545#issuecomment-6214409609
Hey @RussellSpitzer @stevenzwu , I've revised this PR based on the spec proposal we discussed and I proposed: https://github.com/apache/iceberg/pull/18503 I believe we need a common interface for such objects that are encrypted by `EncryptedKey` (an encrypted key metadata). With this we can create an abstraction that works for all of these files through `FileIO` and 'EncryptionManager` regardless if the use the `key-id` + `encryption-keys` list, or the direct `encryption-key` approach. I don't think we can introduce something like `newFileIO(location, length, keyMetadata)` or such to `FileIO` because we seem to keep a contract there not to leak any parameter that is keyMetadata, keyId or such. We rather accept types like `DataFile`, `ManifestFile` and so, and extending this contract with the new interface seems natural to me. I'm not entirely sure about the name of such a new API, but I still lean towards something like `FileWithEncryptedKey` suits the intent the best. Let me know what you think! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
