shangxinli commented on code in PR #1025:
URL: https://github.com/apache/iceberg-cpp/pull/1025#discussion_r4297856504
##########
src/iceberg/json_serde.cc:
##########
@@ -1703,6 +1703,7 @@ Result<nlohmann::json> FromJsonString(const std::string&
json_string) {
if (json.is_discarded()) [[unlikely]] {
return JsonParseError("Failed to parse JSON string: {}", json_string);
}
+ ICEBERG_RETURN_UNEXPECTED(CheckJsonNestingDepth(json));
Review Comment:
This and the puffin one cover two of the three `nlohmann::json::parse`
sites; `catalog/rest/auth/oauth2_util.cc:186` parses a JWT payload straight off
the token endpoint and isn't gated. It only reads the `exp` claim, so leaving
it out may well be deliberate - worth saying so if it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
