ggershinsky commented on code in PR #18440: URL: https://github.com/apache/iceberg/pull/18440#discussion_r4296501506
########## api/src/main/java/org/apache/iceberg/actions/RotateEncryptionKeys.java: ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.actions; + +import org.apache.iceberg.ManifestFile; +import org.apache.iceberg.RotateEncryptionKeys.KeyRegenerationLevel; + +/** + * An action that rotates the encryption keys of a table. + * + * <p>Similar to {@link org.apache.iceberg.RotateEncryptionKeys} but may use a query engine to + * distribute parts of the work. + */ +public interface RotateEncryptionKeys + extends SnapshotUpdate<RotateEncryptionKeys, RotateEncryptionKeys.Result> { + + /** + * Sets the lowest key to regenerate. + * + * @param level the lowest key to regenerate + * @return this for method chaining + */ + RotateEncryptionKeys keyRegenerationLevel(KeyRegenerationLevel level); + + /** The action result that contains a summary of the execution. */ + interface Result { + /** Returns the manifests written with new keys. */ + Iterable<ManifestFile> addedManifests(); Review Comment: seems specific to a single level. Also, "written with new keys" needs clarification. ########## api/src/main/java/org/apache/iceberg/RotateEncryptionKeys.java: ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import java.util.List; + +/** + * API for rotating the encryption keys of a table so that they no longer depend on a superseded + * version of the table master key. + * + * <p>Only the keys reachable from the current snapshot are rotated. Older snapshots keep depending + * on the previous keys until they are expired. + * + * <p>{@link #apply()} returns the manifests that will be replaced. + */ +public interface RotateEncryptionKeys extends PendingUpdate<List<ManifestFile>> { Review Comment: nit: we have two interfaces with the same name. also, "extends PendingUpdate<List<ManifestFile>>" - manifest files are not always replaced. ########## api/src/main/java/org/apache/iceberg/RotateEncryptionKeys.java: ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import java.util.List; + +/** + * API for rotating the encryption keys of a table so that they no longer depend on a superseded + * version of the table master key. + * + * <p>Only the keys reachable from the current snapshot are rotated. Older snapshots keep depending + * on the previous keys until they are expired. + * + * <p>{@link #apply()} returns the manifests that will be replaced. Review Comment: manifest files are not always replaced. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
