Copilot commented on code in PR #3481: URL: https://github.com/apache/iceberg-rust/pull/3481#discussion_r4297731942
########## .asf.yaml: ########## Review Comment: The new `protected_branches` / `rulesets` block appears to be indented two spaces less than the surrounding `github:` config (e.g., compare with `merge:` / `rebase:` above). In YAML, this would move these keys out from under `github:` and likely break or ignore the intended GitHub settings. Align indentation so these keys are under the same `github:` level as the other GitHub settings. ########## .asf.yaml: ########## Review Comment: The previous configuration explicitly set `dismiss_stale_reviews: false`, but that setting is removed in the new ruleset. This can change behavior (stale reviews may be dismissed depending on defaults), which impacts the PR approval workflow. If the intent is to preserve current behavior, add `dismiss_stale_reviews: false` under `required_pull_request_reviews` in the new ruleset. ########## .asf.yaml: ########## Review Comment: This ruleset uses `type: branch`, while the existing ruleset below uses `target: branch` (and also specifies `enforcement`). If the asfyaml schema expects `target` (as implied by the existing “Merge Queue” ruleset), this new ruleset may not be applied. Use the same keys as the working ruleset (`target: branch`, plus an explicit `enforcement`) for consistency and to avoid the ruleset being ignored. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
