rdblue commented on a change in pull request #2132:
URL: https://github.com/apache/iceberg/pull/2132#discussion_r562263772
##########
File path:
spark3-extensions/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteMergeInto.scala
##########
@@ -216,8 +215,10 @@ case class RewriteMergeInto(spark: SparkSession) extends
Rule[LogicalPlan] with
}
private def isCardinalityCheckEnabled(table: Table): Boolean = {
- PropertyUtil.propertyAsBoolean(table.properties(),
- MERGE_WRITE_CARDINALITY_CHECK, MERGE_WRITE_CARDINALITY_CHECK_DEFAULT)
+ PropertyUtil.propertyAsBoolean(
+ table.properties(),
+ MERGE_CARDINALITY_CHECK_ENABLED,
+ MERGE_CARDINALITY_CHECK_ENABLED_DEFAULT)
Review comment:
This has a few places that don't really need to be refomatted, like
this. It should be okay since these are new and it is unlikely that anyone is
cherry-picking these commits, but I'd prefer to avoid them in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
