adityaksolves commented on PR #18517: URL: https://github.com/apache/iceberg/pull/18517#issuecomment-6231162275
Thanks @pvary @mxm. I’ve updated the PR to Flink 2.3 only and will backport to 1.20 and 2.2 once this is merged. Changes: Schemas are now stored in the cache with the current schema first, followed by the rest from newest to oldest. CacheItem no longer keeps currentSchemaId as a field. Historical schemas that contain a retired field id whose name is used again by a live field in the current schema are skipped. I don’t see any additional use-cases beyond the ones you listed. Tests: testSchemaSkipsHistoricalSchemaWithRetiredFieldReusedByName (fails without the filter) and testSchemaStillMatchesHistoricalSchemaWhenDroppedColumnIsNotReAdded (the dropped-and-not-re-added case still matches the older schema). @mxm I haven’t added a direct assertion on the ordering since CacheItem is private; the tests cover it through behavior. Happy to add one if you have a preferred way to expose it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
