kinolaev commented on code in PR #18542:
URL: https://github.com/apache/iceberg/pull/18542#discussion_r4302330074
##########
flink/v2.3/flink/src/test/java/org/apache/iceberg/flink/sink/dynamic/TestDynamicIcebergSink.java:
##########
@@ -1955,14 +1955,7 @@ private void runTest(
Map<String, String> writeProperties)
throws Exception {
executeDynamicSink(
- dynamicData,
- env,
- immediateUpdate,
- parallelism,
- null,
- false,
- writeProperties,
- TableCreator.DEFAULT);
+ dynamicData, env, immediateUpdate, parallelism, null, false,
writeProperties);
Review Comment:
In the original PR, I initially passed `TableCreator.DEFAULT` at the
`executeDynamicSink` call sites, but later added an overload instead. That made
the call site updates redundant. I missed reverting this one earlier and would
like to revert it now.
Is this small cleanup acceptable in a backport PR? If no, I'll apply the
same change to 1.20 and 2.2 to keep them in sync with 2.3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
