Fokko commented on code in PR #3483:
URL: https://github.com/apache/iceberg-rust/pull/3483#discussion_r4302464179
##########
crates/iceberg/src/spec/values/datum.rs:
##########
@@ -1229,6 +1229,19 @@ impl Datum {
&self.r#type
}
+ /// Returns a copy whose literal is widened to `target` for the value
+ /// promotions `int` -> `long` and `float` -> `double`, so a value written
+ /// under the narrower type compares against a predicate bound to the wider
+ /// one. Any other `target` returns an unchanged copy; decimals already
+ /// compare across precisions.
+ pub(crate) fn promote_to(&self, target: &PrimitiveType) -> Datum {
+ match (&self.literal, target) {
+ (PrimitiveLiteral::Int(value), PrimitiveType::Long) =>
Datum::long(*value),
+ (PrimitiveLiteral::Float(value), PrimitiveType::Double) =>
Datum::double(value.0),
+ _ => self.clone(),
+ }
+ }
Review Comment:
I'm lesser known with the PyIceberg codebase, but we could also push this
down into the projected schema when reading the manifest. This way we always
get the current spec.
This avoids having to promote all the values afterwards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
