JeonDaehong commented on code in PR #3253:
URL: https://github.com/apache/iceberg-rust/pull/3253#discussion_r4301730437
##########
crates/iceberg/src/spec/values/datum.rs:
##########
@@ -294,8 +294,12 @@ impl Display for Datum {
fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
match (&self.r#type, &self.literal) {
(_, PrimitiveLiteral::Boolean(val)) => write!(f, "{val}"),
- (PrimitiveType::Int, PrimitiveLiteral::Int(val)) => write!(f,
"{val}"),
- (PrimitiveType::Long, PrimitiveLiteral::Long(val)) => write!(f,
"{val}"),
+ (PrimitiveType::Int | PrimitiveType::Unknown,
PrimitiveLiteral::Int(val)) => {
Review Comment:
I ran this one: `identity(decimal)`, `truncate(decimal)` and
`identity(uuid)` on a dropped source all hit that `unreachable!()`. #3432 adds
those two arms in b765bbf1a (uuid prints like Java, decimal prints the unscaled
value since the scale is gone with the source).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
