shangxinli commented on code in PR #1002:
URL: https://github.com/apache/iceberg-cpp/pull/1002#discussion_r4304187734
##########
src/iceberg/table_scan.cc:
##########
@@ -241,16 +241,19 @@ int64_t FileScanTask::estimated_row_count() const {
}
const int64_t record_count = data_file_->record_count;
- if (record_count <= 0) {
+ const int64_t file_size = data_file_->file_size_in_bytes;
Review Comment:
Dropping Range::file_size means the proration now divides by whatever
file_size_in_bytes reads at call time, so if that metadata does change, as the
comment just above concedes it can, the splits of one file no longer sum to
record_count and some return 0 instead. Capturing the size at MakeSplit is what
made the invariant in the next comment hold.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
