shangxinli commented on code in PR #1026: URL: https://github.com/apache/iceberg-cpp/pull/1026#discussion_r4304187832
########## src/iceberg/util/macros.h: ########## @@ -21,15 +21,18 @@ /// \file iceberg/util/macros.h /// \brief Define common Iceberg utility macros. +/// +/// The macros name Iceberg symbols with their full namespace, so code outside namespace Review Comment: ICEBERG_CHECK_OR_DIE in exception.h:47 is the one public error macro left out of this pass; it still expands to iceberg::IcebergError without the leading colons. Worth folding in so the rule this comment states holds for every macro a caller outside the namespace can reach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
