richiebachala commented on PR #2188: URL: https://github.com/apache/iceberg-go/pull/2188#issuecomment-6240876259
Thanks @Revanth14, verified against 76281de. I reran my repro on this commit, extended to mutate field labels as well as object labels, through both the first table and a cached one: each load now gets independent labels. Your tests and `go test -race ./catalog/rest` pass too. Good catch on copying in `put` as well as on a hit. I'd only suggested the hit side, which would still have left the first load's table sharing the stored pointer. The mode check reads well too, and keeping the key to the identifier for one-entry invalidation makes sense. LGTM from my side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
