richiebachala commented on PR #2190: URL: https://github.com/apache/iceberg-go/pull/2190#issuecomment-6240972458
Thanks @laskoviymishka, all addressed in cb65048. - **Bootstrap moved to a script.** It's now `internal/recipe/setup-polaris.sh`, next to the compose file so an integration job can reuse it; CONTRIBUTING is down to a pointer and the `go test` line. - **Recipe fragility.** The readiness wait is bounded at 60s and prints `docker logs` on timeout; the token goes through `jq -e`; every call uses `curl --fail-with-body`, so a 401 shows its body instead of a bare exit 22. I forced each case to check: a missing image, wrong credentials, and a crash-looping server all now exit non-zero with the cause visible. - **Rerun.** The script replaces its own container (`iceberg-go-polaris`) each run, so rerunning it works rather than hitting the name clash and the catalog 409. - **`ignore-severe-issues`.** One correction to the assumption: it isn't silencing an optional check. Without it, Polaris exits at startup, since its production-readiness checks classify FILE storage as a severe risk. The comment now says so. - **Credential check.** Taken: `require.Contains(..., ":")`. A bare secret now fails immediately with that message. - **Self-rename branch.** `RenameTableToSelf` now logs which outcome it took, in `catalogtest`, so it covers every backend. The Java fixture logs a no-op success and Polaris logs a rejection, so a change in either shows up in the logs. I didn't add an expected-outcome field to `Config`; happy to if you'd rather a change fail the run instead of just showing in the log. On compose vs opt-in: agreed that a test that skips in CI won't catch breakage. The script is written so an integration job can call it directly. Once @zeroshade weighs in, I can add the Polaris service and job here or as a follow-up, whichever you both prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
