yusufyildiz34 opened a new pull request, #18579: URL: https://github.com/apache/iceberg/pull/18579
Since #15249, `AwsClientProperties#credentialsProvider` puts `credentials.uri` into the properties handed to a custom `client.credentials-provider` even when no refresh endpoint is configured, so the provider receives a null value. Providers that re-read those properties through `AwsClientProperties` then fail with an NPE in `PropertyUtil.filterProperties`. This applies the same null/empty check the `VendedCredentialsProvider` branch already uses. It continues #17540 and #17752, which closed without merging; reviewers there asked for a regression test, which this adds. Closes #17536 Test plan: `customCredentialsProviderWithoutRefreshEndpoint` fails on main (the provider receives `credentials.uri=null`) and passes with the fix; `customCredentialsProviderTakesPrecedence` now also asserts the endpoint is still passed when configured. --- **AI Disclosure** - Model: Claude Opus 5.5 - Platform/Tool: Claude Code - Human Oversight: fully reviewed - Prompt Summary: Investigate #17536, reproduce it with a failing test in TestAwsClientProperties, and apply the null guard reviewers agreed with on #17540. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
