YinZheng-Sun commented on code in PR #956:
URL: https://github.com/apache/iceberg-cpp/pull/956#discussion_r4311910826
##########
src/iceberg/expression/evaluator.cc:
##########
@@ -140,6 +141,7 @@ Result<std::unique_ptr<Evaluator>> Evaluator::Make(const
Schema& schema,
std::shared_ptr<Expression>
unbound,
bool case_sensitive) {
ICEBERG_ASSIGN_OR_RAISE(auto bound_expr, Binder::Bind(schema, unbound,
case_sensitive));
+ ICEBERG_ASSIGN_OR_RAISE(bound_expr, RewriteNot::Visit(bound_expr));
Review Comment:
Done: UUID literals are now compared as unsigned bytes, matching the Parquet
UUID sort order, RFC 9562, and iceberg-rust/go. Note that Java currently
compares via `java.util.UUID.compareTo` (signed longs), which is a known bug
(apache/iceberg#14216, fix in apache/iceberg#14500). Manifest partition
summaries written by Java may therefore use signed order; handling that (e.g.
the dual-comparator fallback in #14500) seems better as a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
