yusufyildiz34 opened a new pull request, #18586: URL: https://github.com/apache/iceberg/pull/18586
`AssumeRoleAwsClientFactory` builds its Glue and KMS clients without applying `glue.endpoint` and `kms.endpoint`, while its DynamoDB client and `DefaultAwsClientFactory` apply them, so assume-role users can't point Glue or KMS at a custom endpoint. `LakeFormationAwsClientFactory` has the same gap for the KMS client it builds for registered tables. This applies the existing `AwsProperties` endpoint configurations in those three builders. Catalogs that already set these properties with an assume-role factory will now use them. It continues #17049, which the stale bot closed without review. Closes #17047 Test plan: three `TestAwsClientFactories` cases check the endpoint override on the assume-role Glue and KMS clients and on the Lake Formation KMS client for a registered table; all fail on main and pass with this change. --- **AI Disclosure** - Model: Claude Opus 5.5 - Platform/Tool: Claude Code - Human Oversight: fully reviewed - Prompt Summary: Investigate #17047, reproduce it with failing TestAwsClientFactories cases, and apply the missing endpoint configurations in the assume-role and Lake Formation client factories. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
