binarybrain-009 commented on issue #17135: URL: https://github.com/apache/iceberg/issues/17135#issuecomment-6284676487
@AbdelrahmanElhawary #17143 was closed by the stale bot before anyone reviewed it. If you aren't planning to reopen it, I'd like to pick this up and keep you as co-author. I'd fix it in `GenericArrowVectorAccessorFactory`, which is where every reader of a dictionary-encoded vector decodes its values: `TIMESTAMP_MILLIS` currently shares `DictionaryLongAccessor` with plain longs, so it would get its own accessor that converts to microseconds, the same way INT96 timestamps have `DictionaryTimestampInt96Accessor`. The test would write a fully dictionary-encoded millis column and check that the vectorized reader returns microseconds, with and without UTC adjustment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
