anuragmantri commented on PR #18401: URL: https://github.com/apache/iceberg/pull/18401#issuecomment-6284360829
Thanks @pvary. I updated the description, and the config docs and Javadoc now say the values come from the current head of the branch, not from the commits that wrote the rewritten files. I'll send the email to dev@ shortly. On your question about config alone, the cases I can think of are: - Letting each maintenance job read the head's summary and set the keys itself works when the job controls its own code. It doesn't work for `CALL system.rewrite_data_files` or `rewrite_manifests` from SQL, or for a generic maintenance service that doesn't know the writers' keys. - Retaining old snapshots with expiration settings keeps the uncompacted data files alive, which defeats the purpose of compaction. Did you have anything else in mind? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
