fallintoplace opened a new pull request, #2233: URL: https://github.com/apache/iceberg-go/pull/2233
## What - Return stored immutable bytes from `MemFS.Open`. ## Why - Avoid copying the whole file on every in-memory open. ## Implementation - `WriteFile` still copies caller bytes, so open readers keep a stable snapshot after replacement or removal. - Add snapshot and concurrent replacement coverage plus an open benchmark. ## Benchmark - Go 1.26.3, darwin/arm64; base `914040c` vs head `8dad0319`, 10 alternating 300 ms samples, `-cpu=1`. - Open + read last byte + close: 1 MiB 160.7 us -> 46.8 ns (3,431x); 16 MiB 835.4 us -> 42.1 ns (19,853x). Allocations fell from 2 and file-sized bytes to 1 and 48 B/op. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
