zeroshade commented on PR #2235: URL: https://github.com/apache/iceberg-go/pull/2235#issuecomment-6297571692
Thanks! This conflicts with #2232, which just merged and touches the same spots in `table/equality_delete_reader.go`: the `sync.Once` fields next to `singleInt64Once`, and the typed-set slices plus dispatch in `processEqualityDeletesColumnarForFile`. Could you rebase onto main? The logic doesn't overlap, so it should be mechanical: try the Int32, Int64 and bytes sets in turn before falling back to the generic encoder. I'll take a quick look at the rebased diff and merge once CI is green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
