kevinjqliu commented on code in PR #2056:
URL: https://github.com/apache/iceberg-go/pull/2056#discussion_r4328595680
##########
internal/recipe/docker-compose.yml:
##########
@@ -90,21 +90,20 @@ services:
# static S3 credentials used by the fixture's backing FileIO.
- CATALOG_GCS_OAUTH2_TOKEN=scan-planning-integration-token
object-store:
- image: rustfs/rustfs:1.0.0
+ image: rustfs/rustfs:1.0.3
container_name: object-store
environment:
- RUSTFS_ACCESS_KEY=admin
- RUSTFS_SECRET_KEY=password
- RUSTFS_SERVER_DOMAINS=object-store
- RUSTFS_OBS_LOG_STDOUT_ENABLED=true
+ - RUSTFS_CONSOLE_ENABLE=false
Review Comment:
removes console port 9001, we dont need it
##########
internal/recipe/docker-compose.yml:
##########
@@ -90,21 +90,20 @@ services:
# static S3 credentials used by the fixture's backing FileIO.
- CATALOG_GCS_OAUTH2_TOKEN=scan-planning-integration-token
object-store:
- image: rustfs/rustfs:1.0.0
+ image: rustfs/rustfs:1.0.3
container_name: object-store
environment:
- RUSTFS_ACCESS_KEY=admin
- RUSTFS_SECRET_KEY=password
- RUSTFS_SERVER_DOMAINS=object-store
- RUSTFS_OBS_LOG_STDOUT_ENABLED=true
+ - RUSTFS_CONSOLE_ENABLE=false
networks:
iceberg_net:
aliases:
- warehouse.object-store
ports:
- - 9001:9001
- 9000:9000
- command: ["/data"]
Review Comment:
this is the default, can remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
